This code completely fails to take into account caches out in front of
the gadget renderer, which will cause this to break for anyone using a
reverse proxy that does caching. Given that everyone who wants to deploy
separate servers for gadget rendering and social data access needs a
reverse proxy, there needs to be much more done here.


http://codereview.appspot.com/63210/diff/1/8
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/SmartRpcJsFeatureLoader.java
(right):

http://codereview.appspot.com/63210/diff/1/8#newcode104
Line 104: StringBuffer allOpt = new StringBuffer();
There is no good reason why we should be using StringBuffers here.

http://codereview.appspot.com/63210

Reply via email to