Hi Paul:

You're absolutely right. Vary: User-Agent; is preferable to me. Do you
have any reason in mind for why Cache-Control: private in addition to or
instead of Vary would be preferable? Ie. common support by various CDNs.

I've been thinking how best to link service of custom rpc to setting
this header. Ultimately JsServlet or a Filter needs to do so. Thoughts
on this? The best idea I had was to add something like
isBrowserSpecific() to JsLibrary so that the relevant output code
(gadget rendering, js servlet) could act accordingly.

Kevin - re: StringBuffer, comment isn't particularly prescriptive so
I'll assume the complaint is use of StringBuffer rather than
StringBuilder. If so, fixed. If not, let me know.

http://codereview.appspot.com/63210

Reply via email to