looking good.


http://codereview.appspot.com/174079/diff/1001/1002
File java/common/src/main/java/org/apache/shindig/common/uri/Uri.java
(right):

http://codereview.appspot.com/174079/diff/1001/1002#newcode68
java/common/src/main/java/org/apache/shindig/common/uri/Uri.java:68:
any particular reason we use a linkedhashmap here?  IIRC ImmutableMap
returns items in the order they were inserted as well.

Might want to consider a ImmutableMultimap too..

http://codereview.appspot.com/174079/diff/1001/1003
File
java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java
(right):

http://codereview.appspot.com/174079/diff/1001/1003#newcode49
java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java:49:

Again, a Multimap would be useful here...

http://codereview.appspot.com/174079/diff/1001/1021
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
(right):

http://codereview.appspot.com/174079/diff/1001/1021#newcode174
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java:174:
String[] libs = path.split(JS_DELIMITER);
Is JS_DELIMITER a regex?  If not, then consider using
StringUtils.split()

http://codereview.appspot.com/174079/diff/1001/1009
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java
(right):

http://codereview.appspot.com/174079/diff/1001/1009#newcode55
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java:55:

example.com would be better..  (as much as I love apache :)

http://codereview.appspot.com/174079

Reply via email to