Hey Paul: thanks for taking a look. Converted apache.org -> example.com
in the tests, and used StringUtils.split(...) rather than
String.split(...) for efficiency, as suggested.

Re: LinkedHashmap vs. Multimap -- not really sure actually. I didn't
implement the original one; and just did a copy-and-paste in this
edition. The javadoc of Multimap doesn't make it clear that order is
maintained, though it might be a property of the impl:
http://commons.apache.org/collections/api-release/org/apache/commons/collections/MultiMap.html
(just says "Collection will be returned").

Updating w/ a new patch shortly. This is just a minor patch update
though -- patch #3 to include UriBuilder cleanup (at least only 1 shared
impl of XParams, query or fragment) and DefaultIframeUriManagerTests.

http://codereview.appspot.com/174079

Reply via email to