Hi,
Ok, after all if we want to say "no timeperiod" is 24x7, it's next_valid =
now and is_valid_time(now) = true. Let add this behaviour in 0.5.
We should also remind us to update the doc too :p
Jean
On Tue, Dec 7, 2010 at 5:19 PM, NICOLAS DUPEUX <nicolas.dup...@arkea.com>wrote:
> > > The attached patch default notification_period to 24x7
> > That would require the existence of a 24x7 timeperiod. What if the
> > config
> > doesn't know such a definition?
> > Did you look into the Nagios code? Does it simply insert the string
> > "24x7"
> > (so it can fail later with "no timeperiod 24x7 found")?
>
> I've tried to look into the nagios code.... It's looks like it's handle
> gracefuly the case when notification_period is NULL :
> base/notifications.c:
> /* see if the host can have notifications sent out at this time */
>
>
> if(check_time_against_period(current_time,hst->notification_period_ptr)==ERROR){
>
> log_debug_info(DEBUGL_NOTIFICATIONS,1,"This host shouldn't
> have notifications sent out at this time.\n");
>
> base/utils.c:
> int check_time_against_period(time_t test_time, timeperiod *tperiod){
> [...]
> /* if no period was specified, assume the time is good */
> if(tperiod==NULL)
> return OK;
>
> So my patch doesn't make shinken follow nagios behavior.
>
> Regards,
>
>
> --
> Nicolas DUPEUX <nicolas.dup...@arkea.com>
> Arkea - Domaine Systèmes
> tel : 02.98.00.36.68
>
> --
> Ce message et toutes les pieces jointes (ci-apres le "message") sont
> confidentiels et etablis a l'intention exclusive de ses destinataires.
> Toute utilisation ou diffusion non autorisee est interdite. Tout
> message etant susceptible d'alteration, l'emetteur decline toute
> responsabilite au titre de ce message s'il a ete altere, deforme ou
> falsifie.
> -----------------------------------
> This message and any attachments (the "message") are confidential and
> intended solely for the addressees. Any unauthorised use or
> dissemination is prohibited. As e-mails are susceptible to alteration,
> the issuer shall not be liable for the message if altered, changed
> or falsified.
>
>
> ------------------------------------------------------------------------------
> What happens now with your Lotus Notes apps - do you make another costly
> upgrade, or settle for being marooned without product support? Time to move
> off Lotus Notes and onto the cloud with Force.com, apps are easier to
> build,
> use, and manage than apps on traditional platforms. Sign up for the Lotus
> Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
> _______________________________________________
> Shinken-devel mailing list
> Shinken-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/shinken-devel
>
------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel
