On 03/27/2012 06:37 AM, Togan Muftuoglu wrote:
> On 03/26/2012 02:12 AM, Tom Eastep wrote:
>> Beta 3 is now available for testing.
>>
>> shorewallrc.apple
>> shorewallrc.archlinux
>> shorewallrc.cygwin
>> shorewallrc.debian
>> shorewallrc.default (for HOST 'linux')
>> shorewallrc.redhat
>> shorewallrc.suse
>
> First great job in working to ease the installation workload.
> Couple of things related to shorewallrc.suse since I am the maintainer
> of shorewall packages in openSUSE and some thoughts in general as I am
> sure other packagers do have their opinion as well.
>
> shorewallrc.suse:
> LIBEXECDIR=${USR}/libexec is wrong there is no directory as libexec it
> is lib hence it should be as follows
> LIBEXECDIR=${USR}/lib
>
> Here are some warnings I am getting
> shorewall-core:
>
> install.sh: line 138: local: can only be used in a function
>
> shorewall6-lite:
>
> install.sh: line 147: local: can only be used in a function
>
> shorewall-init:
> install.sh: line 132: local: can only be used in a function
All have been corrected in Beta 4.
>
> Now apart from these changes as a whole I am not so happy about this
> shorewallrc.vendor approach you have made hard coded destinations and
> this does not fit to the previously discussed rpmmacros approach.
>
> I do not like the idea of installing the following under
> /usr/share/shorewall they belong to %perl_vendorlib as they are modules
>
>
> Shorewall/Accounting.pm
> Shorewall/Chains.pm
> Shorewall/Compiler.pm
> Shorewall/Config.pm
> Shorewall/IPAddrs.pm
> Shorewall/Misc.pm
> Shorewall/Nat.pm
> Shorewall/Proc.pm
> Shorewall/Providers.pm
> Shorewall/Proxyarp.pm
> Shorewall/Raw.pm
> Shorewall/Rules.pm
> Shorewall/Tc.pm
> Shorewall/Tunnels.pm
> Shorewall/Zones.pm
>
> I would rather go back to the 4.5.1 install and packaging routine which
> used the rpmmacros
And I'm trying to get out of the business of creating custom installers
for each distribution.
What I'm considering is:
1. Retain the shorewallrc.* files. They will provide default values.
2. Use a variation of Mr Dash Four's configure script. The config file
it builds will use the settings in shorewallrc.%{_vendor} as
defaults and override directory settings from rpmmacros. That is
necessary because the installers need information
that isn't known to rpm.
-Tom
--
Tom Eastep \ When I die, I want to go like my Grandfather who
Shoreline, \ died peacefully in his sleep. Not screaming like
Washington, USA \ all of the passengers in his car
http://shorewall.net \________________________________________________
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
