On 01/21/2013 09:08 AM, Tom Eastep wrote: > I've found a couple of more issues with 4.5.13 Beta 2. > > 1) An internal error can be raised while trying to complete a built-in > chain like INPUT. > > 2) Audited RELATED_DISPOSITION (e.g., RELATED_DISPOSITION=A_ACCEPT) is > effectively ignored. > > Patches attached.
Here's a fix on top of the second patch above; it avoids perl diagnostics when RELATED_DISPOSITION is 'REJECT'. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
commit 32c475193fff40702cfc80f440d4048247fa8424 Author: Tom Eastep <[email protected]> Date: Mon Jan 21 11:50:46 2013 -0800 Another fix for RELATED_DISPOSITION Signed-off-by: Tom Eastep <[email protected]> diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm index fd5a6ed..41da158 100644 --- a/Shorewall/Perl/Shorewall/Rules.pm +++ b/Shorewall/Perl/Shorewall/Rules.pm @@ -881,7 +881,7 @@ sub finish_chain_section ($$$) { $config{RELATED_DISPOSITION}, '' ); - $related_target = ensure_audit_chain( $related_target ) if $targets{$related_target} & AUDIT; + $related_target = ensure_audit_chain( $related_target ) if ( $targets{$related_target} || 0 ) & AUDIT; add_ijump( $relatedref, g => $related_target );
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
