On 03/06/2013 05:24 PM, Mr Dash Four wrote: > >>> Note the double "echo 0 > ..." statement above. >>> >> >> Patch attached. >> > That now works as expected... > >>> "eth2|eth2)" is the equivalent of "eth2)", so this should be optimised >>> >> >> Patch attached. >> > ... and so is this, though I see that I am able to add any > (non-existing/fictitious) interface in the COPY column and shorewall > takes it without much fuss. Should that be allowed?
Probably not. Patch attached. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Providers.pm b/Shorewall/Perl/Shorewall/Providers.pm
index f19f609..3262630 100644
--- a/Shorewall/Perl/Shorewall/Providers.pm
+++ b/Shorewall/Perl/Shorewall/Providers.pm
@@ -228,6 +228,7 @@ sub copy_and_edit_table( $$$$ ) {
#
for ( split ',', $copy ) {
unless ( $copied{$_} ) {
+ fatal_error "Unknown interface ($_)" unless known_interface($_);
push @copy, $_;
$copied{$_} = 1;
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
