Hi Tom, sorry, but one more question regarding
> I would prefer just the modifications. All of the shorewall code (shell > and perl) uses a 4-column indentation style rather than an 8-column. I took a sample piece of code out of Shorewall/install.sh (original.bash) and reformatted it the way I think it is supposed to be formatted (reformatted.bash). To make the difference visible, I attached and highlighted some positions which I think are wrong formatted in original.bash and are now corrected in reformatted.bash. 1) Please tell me if my reformatted.bash is right or wrong. As you may see, my problem is, that I still don't get if you use tab or space for indenting and sometimes it shows like it is OK to start with tab (which I would prefer!) but then after one tab you switch to spaces (looks like you (or whoever contributed the code) used an editor which used tabs AND fake tabs (aka tab/2 in spaces), which is a really bad mix). Finally I attached two screenshots showing you one of my planned modifications as example using the "current style" (modification_current.jpg) and showing you how I would contribute (modification_w_correct_indentation.jpg). 2) Please tell me, regardless of whether reformatted.bash is properly formatted or not, if I should contribute like showing in - modification_current.jpg - modification_w_correct_indentation.jpg - just_my_modifications_with_correct_indentation.jpg Well, if you agree that code formation in the existing code isn't consistent, I could first commit using the "current" style and if you want, I could later contribute another patch which will fix the mixed code formation. Doing it that way, we would keep logical commits... Sorry that this mail got that long; As you see, I a really care about code style (maybe a bit too much) and I don't want to add some dirty code to your existing project... P.S: For creating the screenshots I used the wrong EOL, please ignore. Attachments: https://www.dropbox.com/s/4ey5phd3t8emvj1/just_my_modifications_with_correct_indentation.jpg https://www.dropbox.com/s/2ax3jlu0ajq2l0y/modification_current.jpg https://www.dropbox.com/s/bia3i2p6etinwrs/modification_w_correct_indentation.jpg https://www.dropbox.com/s/him0nluudgn51dr/original.jpg https://www.dropbox.com/s/o3iwbju2pihro8t/reformatted.jpg https://www.dropbox.com/s/v7cdcbacvv56qid/original.bash https://www.dropbox.com/s/ovqfmkprhanyk7k/reformatted.bash -Thomas ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
