On 09/11/2013 03:21 AM, Thomas D. wrote: > > 1) Please tell me if my reformatted.bash is right or wrong.
It is wrong. > > > As you may see, my problem is, that I still don't get if you use tab or > space for indenting and sometimes it shows like it is OK to start with > tab (which I would prefer!) but then after one tab you switch to spaces > (looks like you (or whoever contributed the code) used an editor which > used tabs AND fake tabs (aka tab/2 in spaces), which is a really bad mix). See below. > > Finally I attached two screenshots showing you one of my planned > modifications as example using the "current style" > (modification_current.jpg) and showing you how I would contribute > (modification_w_correct_indentation.jpg). > > 2) Please tell me, regardless of whether reformatted.bash is properly > formatted or not, if I should contribute like showing in > > - modification_current.jpg > > - modification_w_correct_indentation.jpg > > - just_my_modifications_with_correct_indentation.jpg > I prefer modification_current.jpg. I use Emacs exclusively with an indentation of 4 columns. As you suggested above, Emacs inserts a combination of tabs and spaces (tabs to reach the desired offset modulo 8 then 4 additional spaces if the offset is not a multiple of 8). All of the Shorewall code (shell and perl) is formatted that way. Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
