-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 10/05/2016 09:05 AM, Tom Eastep wrote:
> On 10/05/2016 04:16 AM, Louis Lagendijk wrote:

>> Request 2: shorewall remote-reload and friends require the
>> remote system name to be specified. Would it be possible to check
>> a parameter  (for example from params) and make the system name 
>> optional? This will avoid the risk of reloading the wrong system
>> if the admin is absent minded :-)
> 
> Request 2:
> 
> I will do something in Shorewall 5.0.13.
> 

I looked at this and there is a compatibility problem. Let's take the
remote-start command:

Syntax is:

   remote-start [ <options> ] [ <directory> ] <system>

The requested change would make this:

   remote-start [ <options> ] [ <directory> ] [ <system> ]

Now, if the user types:

   shorewall remote-restart foo

is 'foo' the directory name or the system name? We need to know which
directory to look in to read params and shorewall.conf to learn if the
new shell variable holding the system name is set.

The solution that comes to mind is to implement this syntax:

   remote-start [ <options> ] [ [ -D ] <directory> ] [ <system> ]

In other words, make the directory name one of the <options>. The -D
would only be required when it was desired to omit <system> and still
supply <directory>

Any comments?

- -Tom
- -- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: GPGTools - http://gpgtools.org

iQIcBAEBCAAGBQJX9WxGAAoJEJbms/JCOk0QUEsP/0i3vGhk45lB4jy7wDzB1fOy
8KRZQh6ujYp1qNy+YVagmFyiXo6qarwIK6AICY1KGPlm54awVC7gUwmhwgfkWcS1
3FXwg1dLbAcjnj3tfmVd42PGEKQ7DNkClFCJNTH3s6BVa8QWGAjUIVo8iSalSwn7
QC69jk38g5F2Fcwn1QEACDvKNFwG3UHb/FfOTek9E2DWAOisdjk46ysjEAK2jSAI
uN3te0j+ZOtf5PSa5u/XUP+4sd3X3aTUMuYVsueFzRdr+n7m7Ia8XhrmoP7reiwK
cKOrNn1QHxDzPtncxat8LDCaMyZPTNuLJ/DdqjBHjMX1CP90fttVEhLvW00fRW3k
bLb769iAb8WNRyHPqxFmfD9ea/zNX12B0mAtjFhDMHi/P2JiJ+o0Izvzt2Rj+jHN
8V/cD3t8LNgdIj6dU2y+C4WVsM7Sp7ELgfa/mgvSR2R4p3gUTvojlVVtRPK2dOej
oev7XhwYa0XEt0Oa/RjsIsXen9Kwfy+ORpnfBAEZFfofgUfxfqLAioWMb++s91Vk
AhFmvMLwkn+6WrIN/ows1SUCZfOZPwWZQRiIVcL94YrhTqLBr2+SroylC9dzUvXI
s1jPj92j1osxX5ASKGm4uah4xlkEP6IDijiPikXcdEv9ANfu2woLsVhkqyhAzXqa
f0Mi+q4NEtITX0vEmUlo
=Xsmb
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to