On Wed, 2016-10-05 at 14:10 -0700, Tom Eastep wrote: > On 10/05/2016 09:05 AM, Tom Eastep wrote: > > > > On 10/05/2016 04:16 AM, Louis Lagendijk wrote: > > > > > > > > > Request 2: shorewall remote-reload and friends require the > > > remote system name to be specified. Would it be possible to check > > > a parameter (for example from params) and make the system name > > > optional? This will avoid the risk of reloading the wrong system > > > if the admin is absent minded :-) > > > > Request 2: > > > > I will do something in Shorewall 5.0.13. > > > > I looked at this and there is a compatibility problem. Let's take the > remote-start command: > > Syntax is: > > remote-start [ <options> ] [ <directory> ] <system> > > The requested change would make this: > > remote-start [ <options> ] [ <directory> ] [ <system> ] > > Now, if the user types: > > shorewall remote-restart foo > > is 'foo' the directory name or the system name? We need to know which > directory to look in to read params and shorewall.conf to learn if > the > new shell variable holding the system name is set. > > The solution that comes to mind is to implement this syntax: > > remote-start [ <options> ] [ [ -D ] <directory> ] [ <system> ] > > In other words, make the directory name one of the <options>. The -D > would only be required when it was desired to omit <system> and still > supply <directory> > > Any comments? > > -Tom Hi Tom, Thanks for looking into this. You suggestion looks ok to me. You may also want to consider remote-start [ <options> ] [ <directory> ] [ [-S] <system> ] as the system option may become much less frequently used once it can be set from the configuration.
But as said before the other option is fine with me too. BR, Louis ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
