Hi Frederik,
Note that I am not part of the Yorba team, I am an external contributor
like you so sending me emails to my personal address will not resolve
your problem as I cannot help.
I was just explaining what is Yorba's preferred method to receive
patches to help you get your patches merged. This is the method I've
followed with my own patches. If you can follow the same method as
everybody else, it will simplify the process for the core team and will
help getting your patches reviewed and accepted in a timely manner. If
you decide that you do not want to follow that preferred approach, it is
not for me to say whether your alternative method is acceptable to the
Yorba team or not.
I hope this helps.
Bruno
On 25/11/11 17:31, Frederik Sdun wrote:
No.
I send you a git URL with my patches included. Then you are able to do
the following:
git add origin playya $URL
git pull playya my-fixed-branch
/* test stuff */
git push
btw. there's a git send-mail to send patches directly (needs to be
recompiled on ubuntu to get ssl support IIRC)
Regards, Frederik
2011/11/25 Bruno Girin <[email protected]
<mailto:[email protected]>>
I'm not sure I understand your question. Anyway, what you can also
do is:
git diff origin > some-file
in which case you should be able to upload a single file to the
bug report.
On 24/11/11 21:21, Frederik Sdun wrote:
I waited for a reply in the bug about the interface layout and
didn't push my patches. That's the reason for loosing this
patches.
Is it possible to send a pull request instead of sending a lot
of packages via email?
Am 24.11.2011 19:09, schrieb Bruno Girin:
Hi Frederik,
The Yorba team are the only ones to have the ability to
push commits to master so I'm not surprised that yours got
lost. The best way to get the team to review and integrate
your patches is to use git format-patch and to attach the
resulting file(s) to the redmine ticket. If there is no
ticket, then create one. This process enables the core
team to have a single place to receive patches and to
ensure that all patches are reviewed before being included
in trunk.
I hope this helps.
Cheers,
Bruno
On 24/11/11 12:07, Frederik Sdun wrote:
Hi,
I just pulled HEAD and realized the shotwell has a
faces feature. Really
nice stuff.
I already fixed a small bug and added a simple auto
completion feature: [0]
.
Next bug will be the "boxes bug" which doesn't allow
me to mark people from
bottom-right to top-left and maybe grouping people.
Maybe I will have some time to continue my work on the
tethered shooting
plugin. I did push all of my commits and they're lost.
But here's my last
state: [1] and the bug [2] . Comments welcome.
Another idea is to to port some code from Hugin and
Illuminance to vala to
get panorama and HDR functionalitiy.
Regards, Frederik
[0] https://github.com/playya/shotwell
[1] https://code.launchpad.net/~playya/+junk/shotwell
<https://code.launchpad.net/%7Eplayya/+junk/shotwell>
[2] http://redmine.yorba.org/issues/2895
_______________________________________________
Shotwell mailing list
[email protected] <mailto:[email protected]>
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
_______________________________________________
Shotwell mailing list
[email protected] <mailto:[email protected]>
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
_______________________________________________
Shotwell mailing list
[email protected] <mailto:[email protected]>
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
_______________________________________________
Shotwell mailing list
[email protected] <mailto:[email protected]>
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
_______________________________________________
Shotwell mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
