Frederik,
as Bruno mentioned, we usually accept code contributions via patches
attached to Redmine tickets. But I think a pull request is OK too. To
make such a request, simply add a comment to the ticket in question
(such as http://redmine.yorba.org/issues/2895) with the URL of your
changes, and change the ticket's status from Open to Review. Thanks!
adam
On 11/24/2011 01:21 PM, Frederik Sdun wrote:
I waited for a reply in the bug about the interface layout and didn't
push my patches. That's the reason for loosing this patches.
Is it possible to send a pull request instead of sending a lot of
packages via email?
Am 24.11.2011 19:09, schrieb Bruno Girin:
Hi Frederik,
The Yorba team are the only ones to have the ability to push commits
to master so I'm not surprised that yours got lost. The best way to
get the team to review and integrate your patches is to use git
format-patch and to attach the resulting file(s) to the redmine
ticket. If there is no ticket, then create one. This process enables
the core team to have a single place to receive patches and to ensure
that all patches are reviewed before being included in trunk.
I hope this helps.
Cheers,
Bruno
On 24/11/11 12:07, Frederik Sdun wrote:
Hi,
I just pulled HEAD and realized the shotwell has a faces feature.
Really
nice stuff.
I already fixed a small bug and added a simple auto completion
feature: [0]
.
Next bug will be the "boxes bug" which doesn't allow me to mark
people from
bottom-right to top-left and maybe grouping people.
Maybe I will have some time to continue my work on the tethered
shooting
plugin. I did push all of my commits and they're lost. But here's my
last
state: [1] and the bug [2] . Comments welcome.
Another idea is to to port some code from Hugin and Illuminance to
vala to
get panorama and HDR functionalitiy.
Regards, Frederik
[0] https://github.com/playya/shotwell
[1] https://code.launchpad.net/~playya/+junk/shotwell
[2] http://redmine.yorba.org/issues/2895
_______________________________________________
Shotwell mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
_______________________________________________
Shotwell mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
_______________________________________________
Shotwell mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
_______________________________________________
Shotwell mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
