On Fri, 31 Oct 2025 14:34:10 +0100
Ladislav Laska <[email protected]> wrote:

> Hello All,
> 
> I've processed a few PRs on github:
> 
> * raspberrypi-pico: Add link to firmware repo #268
> * support SWIG 4.2 and later #253
> * Fix Deprecations in libzip and libcheck APIs #265
> * hardware/beaglelogic: Don't include incorrect header <sys/errno.h> #267
> * README.devices: Fix typo #264
> * configure: Fix bashism in _SR_DRIVER #263
> * Update vc96.c #234
> 
> To adhere to the commit style and make it as easy as possible to pull
> into mainline, I've prepared "integration branch":

thanks a lot for doing that. Although we should be asking the
submitters in the future, it might even serve a "still interested?"
check.

> https://github.com/sigrokproject/libsigrok/compare/master...Krakonos:libsigrok:master

I will try take a closer look during the weekend. One improvement could
be adding "Closes: https://github.com/sigrokproject/libsigrok/pull/
<XYZ>" lines into the commit messages, so there is a cross reference to
the original submission that can contain useful technical discussion,
etc. But again, thanks for you work so far, Ladislav :-)


                Dan
 
> @Soeren, 
> 
> I think you can pull as is into mainline and close all of the
> abovementioned PRs. A few caveats that I don't know how to solve with
> this workflow:
> 
> * Commit hashes have changed, just because of the rebase.
> * I have edited some commit messages to adhere to the commit message
>   style (I hope I did a passable job there).
> * In the vc96 case, I've also squashed the commits as there was a lot of
>   incremental work.
> * In all cases I've kept the author & date information in
>   the commits.
> 
> ... However, I feel for those small PRs it's more efficient way to do
> it, as the alternative would mean asking for tiny changes & rebases from
> each author independently.
> 
> Let me know how this works for you and how we should continue moving
> forward. I'm happy to hear feedback on improving the process for
> everybody, so don't hesitate to speak up!
> 
> Next, I'll be moving into the I2S decoders by @endolith and will likely
> do the same there unless there are objections.
> 
> Best regards,
> Ladislav
> 
> 
> -- 
> S pozdravem Ladislav "Krakonoš" Láska                http://www.krakonos.org/
> 
> 
> _______________________________________________
> sigrok-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sigrok-devel


_______________________________________________
sigrok-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to