Hi! > thanks a lot for doing that. Although we should be asking the > submitters in the future, it might even serve a "still interested?" > check.
True, and this is definitely the way to go moving forward. In this case, I took it on myself, since the project kind of owes a small favor to all the developers that posted many months or event years ago. Some of them may not even be around. The cases were also so small it wasn't worth the back and forth. > > > https://github.com/sigrokproject/libsigrok/compare/master...Krakonos:libsigrok:master > > I will try take a closer look during the weekend. One improvement could > be adding "Closes: https://github.com/sigrokproject/libsigrok/pull/ > <XYZ>" lines into the commit messages, so there is a cross reference to > the original submission that can contain useful technical discussion, > etc. But again, thanks for you work so far, Ladislav :-) I considered this, ended up not doing it since some PRs are in multiple commits, so there is not a single place to put it (since the project does prefer rebased fast-forward merges instead of merge commits). I could put it into the last one, or all of them. We can give it some thought and decide later on how to proceed there. > > Dan > > > @Soeren, > > > > I think you can pull as is into mainline and close all of the > > abovementioned PRs. A few caveats that I don't know how to solve with > > this workflow: > > > > * Commit hashes have changed, just because of the rebase. > > * I have edited some commit messages to adhere to the commit message > > style (I hope I did a passable job there). > > * In the vc96 case, I've also squashed the commits as there was a lot of > > incremental work. > > * In all cases I've kept the author & date information in > > the commits. > > > > ... However, I feel for those small PRs it's more efficient way to do > > it, as the alternative would mean asking for tiny changes & rebases from > > each author independently. > > > > Let me know how this works for you and how we should continue moving > > forward. I'm happy to hear feedback on improving the process for > > everybody, so don't hesitate to speak up! > > > > Next, I'll be moving into the I2S decoders by @endolith and will likely > > do the same there unless there are objections. > > > > Best regards, > > Ladislav > > > > > > -- > > S pozdravem Ladislav "Krakonoš" Láska > > http://www.krakonos.org/ > > > > > > _______________________________________________ > > sigrok-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/sigrok-devel > > > _______________________________________________ > sigrok-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/sigrok-devel -- S pozdravem Ladislav "Krakonoš" Láska http://www.krakonos.org/ _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
