Bogdan Brezoi wrote: > Hi, > > Regarding this issue, i have a patch with the client-side prepared. I > still have to write some more tests ( test for the web service - in ruby > i think ) before I'll put the patch but for now, on my machine , the > precommit operation fails at integration tests because of the jain-sip > related code i suppose.
[...] Bogdan this is in a pretty good shape now from my perspective. I do not see any test failures. I would be OK with taking it to mainline. Do you want to somehow coordinate it with preflight changes or can we go ahead to take sipXconfig part now? I reviewed your changes and added a patch with my changes on top of it. It changes TestDb into TestIntegration. Please do not write any more DB tests, Integration tests are easier to write and faster to execute (no need to clean DB, integration tests just roll back DB transactions). The only thing that is missing at the moment is test for getUnregisteredDiscoveredDevices method that you just added, but it can be added later. BTW "unregistered" is probably not the best terminogy since it is usually associated with SIP registration. I think in this case you just mean discovered devices that are not managed by sipXconfig yet. But as I said: we can change it later. D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
