Revision: 16181
http://sourceforge.net/p/skim-app/code/16181
Author: hofman
Date: 2026-04-06 14:36:30 +0000 (Mon, 06 Apr 2026)
Log Message:
-----------
don't check user defaults when we're already not animating
Modified Paths:
--------------
trunk/SKBookmarkController.m
trunk/SKMainWindowController.m
trunk/SKStatusBar.m
Modified: trunk/SKBookmarkController.m
===================================================================
--- trunk/SKBookmarkController.m 2026-04-06 09:01:49 UTC (rev 16180)
+++ trunk/SKBookmarkController.m 2026-04-06 14:36:30 UTC (rev 16181)
@@ -365,7 +365,7 @@
- (void)replaceBookmarksAtIndexes:(NSIndexSet *)indexes ofBookmark:(SKBookmark
*)bookmark withBookmarks:(NSArray *)newBookmarks animate:(BOOL)animate {
NSIndexSet *removeIndexes = indexes ?: [NSIndexSet
indexSetWithIndexesInRange:NSMakeRange(0, [bookmark countOfChildren])];
- if ([NSView shouldShowSlideAnimation] == NO)
+ if (animate && [NSView shouldShowSlideAnimation] == NO)
animate = NO;
if ([removeIndexes count] > 0)
[self removeBookmarksAtIndexes:removeIndexes ofBookmark:bookmark
animate:animate];
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2026-04-06 09:01:49 UTC (rev 16180)
+++ trunk/SKMainWindowController.m 2026-04-06 14:36:30 UTC (rev 16181)
@@ -1638,7 +1638,7 @@
if ([overviewView window])
return;
- if ([NSView shouldShowFadeAnimation] == NO)
+ if (animate && [NSView shouldShowFadeAnimation] == NO)
animate = NO;
if (overviewView == nil) {
@@ -1727,7 +1727,7 @@
if (window == nil)
return;
- if ([NSView shouldShowFadeAnimation] == NO)
+ if (animate && [NSView shouldShowFadeAnimation] == NO)
animate = NO;
// don't check interactionMode as this can be called from
enterPresentation/exitPresentation
Modified: trunk/SKStatusBar.m
===================================================================
--- trunk/SKStatusBar.m 2026-04-06 09:01:49 UTC (rev 16180)
+++ trunk/SKStatusBar.m 2026-04-06 14:36:30 UTC (rev 16181)
@@ -152,7 +152,7 @@
- (void)toggleBelowView:(NSView *)view animate:(BOOL)animate {
if (animating)
return;
- if ([NSView shouldShowSlideAnimation] == NO)
+ if (animate && [NSView shouldShowSlideAnimation] == NO)
animate = NO;
NSView *contentView = [view superview];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
