Revision: 16182
http://sourceforge.net/p/skim-app/code/16182
Author: hofman
Date: 2026-04-06 14:46:09 +0000 (Mon, 06 Apr 2026)
Log Message:
-----------
check whether to really animate in place
Modified Paths:
--------------
trunk/SKMainWindowController.m
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2026-04-06 14:36:30 UTC (rev 16181)
+++ trunk/SKMainWindowController.m 2026-04-06 14:46:09 UTC (rev 16182)
@@ -1638,9 +1638,6 @@
if ([overviewView window])
return;
- if (animate && [NSView shouldShowFadeAnimation] == NO)
- animate = NO;
-
if (overviewView == nil) {
overviewView = [[SKOverviewView alloc] init];
NSScrollView *scrollView = [[NSScrollView alloc] init];
@@ -1705,7 +1702,7 @@
mwcFlags.thumbnailsUpdatedDuringPresentaton = 1;
}
- if (animate) {
+ if (animate && [NSView shouldShowFadeAnimation]) {
CAAnimation *animation = [CATransition animation];
[animation setDuration:OVERVIEW_DURATION];
[animation setTimingFunction:[CAMediaTimingFunction
functionWithName:kCAMediaTimingFunctionDefault]];
@@ -1727,13 +1724,7 @@
if (window == nil)
return;
- if (animate && [NSView shouldShowFadeAnimation] == NO)
- animate = NO;
-
- // don't check interactionMode as this can be called from
enterPresentation/exitPresentation
- BOOL isPresentation = (window == [presentationView window]);
-
- if (animate) {
+ if (animate && [NSView shouldShowFadeAnimation]) {
CAAnimation *animation = [CATransition animation];
[animation setDuration:OVERVIEW_DURATION];
[animation setTimingFunction:[CAMediaTimingFunction
functionWithName:kCAMediaTimingFunctionDefault]];
@@ -1740,6 +1731,9 @@
[[[overviewContentView superview] layer] addAnimation:animation
forKey:@"animation"];
}
+ // don't check interactionMode as this can be called from
enterPresentation/exitPresentation
+ BOOL isPresentation = (window == [presentationView window]);
+
[overviewContentView removeFromSuperview];
[(isPresentation ? presentationView : [splitViewController view])
setHidden:NO];
[window makeFirstResponder:isPresentation ? presentationView : pdfView];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
