On 12/11/10 6:59 PM, Christiaan Hofman wrote: > Apart from that, your patches have some problems if combined with the > special actions associated to modifiers (shift, option). And perhaps > more, the code is pretty hard to follow, as it is supposed to support > a lot of different and complex actions.
I tried to keep my patches as simple as possible (well, I know there's an extraneous comment in the first patch). The first patch simply switches the order of if-statements so that the one I want gets priority, and the second patch just deselects a new path after it is formed, using the same code that appears in a line above. I didn't write any new code, I just switched the order or copied what is already there; I hope it isn't that hard to follow. I hadn't tested any modifiers; I just barely started using Skim a few months ago, so I'm not yet familiar with all that is possible. I just noticed that in the official version, if I hold shift down as I draw freehand annotations, it makes all of my strokes one connected path (drawing straight lines between the strokes if I draw multiple strokes). I suppose that's one side effect, which doesn't bother me (but of course, I only speak for .00000001% of the users, i.e., me :). If you have the time or inclination, I'd love to learn more about what problems there could be with modifiers and my patches (and I understand if you don't! We're all involved in other things too). This is only the second time that I've modified/written an objective C application or used the Apple APIs; I'm sure I still have a lot to learn about how things are done on OSX. Thanks, Jason ------------------------------------------------------------------------------ Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL, new data types, scalar functions, improved concurrency, built-in packages, OCI, SQL*Plus, data movement tools, best practices and more. http://p.sf.net/sfu/oracle-sfdev2dev _______________________________________________ Skim-app-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/skim-app-users
