On Sun, Aug 22, 2010 at 02:30:51PM +0300, Ozan Türkyılmaz wrote: > 2010/8/22 David Woodfall <[email protected]>: > > On (10:09 22/08/10), emmel <[email protected]> put forth the proposition: > >> > >> What are the opinions on including the DIB engine patch in the build? It > >> has to be enabled manually anyway (environment variable WINEDIB=on), so > >> there shouldn't be any trouble, but it does fix some pointer issues with > >> a couple of programs. > > > > Hi Emmel, will these patches find their way into upstream source in > > due time? I am wary of fixing stuff that should be taken care of > > upstream. > > I don't know how Emmel sees it but I don't think they find their way into > upstream due time. DIBEngine still needs a lot of work and So far DIBEngines > were not cut for upstream quality.
The way I see it I have to manually patch the slackbuild each time I build wine. Fact is these patches won't see there way into upstream anytime soon and that's the case for years, I think. The problem is not so much with the quality of the patches (which don't cause any problems I am aware of and will only come into play when the environment variable is set anyway), but structural decisions. From what I understand the DIB engine that ends up in release wine, some day in distant future, will be made right in respect to wine design guidelines and who knows what, requiring any number of changes to wine. It's more of a religious matters, I think, with some bits of maintainability mixed in. The code originally came from TransGaming... Still, there are quite a few programs out there (for me it's Uru, but have a look at http://appdb.winehq.org/viewbugs.php?bug_id=421) that require it, and it would be nice to at least have the choice, maybe with a configuration variable or something. Naturally, since I am not the maintainer I don't have the final say in the matter, but to make it short: It would be much appreciated and it's not patch that will end up in upstream anytime soone. -- emmel <[email protected]> GPG signed Fingerprint: 60B4 D8E3 9617 900C 6726 168F D677 5AAD D40F CCE7 Certserver : hkp://pgp.mit.edu
pgpuzWEk2RDSu.pgp
Description: PGP signature
_______________________________________________ SlackBuilds-users mailing list [email protected] http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users Archives - http://lists.slackbuilds.org/pipermail/slackbuilds-users/ FAQ - http://slackbuilds.org/faq/
