On Fri, May 16, 2008 at 3:02 PM, David Rees <[EMAIL PROTECTED]> wrote:
> On Fri, May 16, 2008 at 2:39 PM, Jeff Frost <[EMAIL PROTECTED]> wrote:
>> On Fri, 16 May 2008, Christopher Browne wrote:
>>> Jeff Frost <[EMAIL PROTECTED]> writes:
>>>> Hrmmm..I get this when trying to update functions:
>>>>
>>>> ./upgrade.slonik:5: Possible unsupported PostgreSQL version 8.3,
>>>> defaulting to 8.1 support

Looks like there is two places where the versions are checked in
slonik.c, around like 1900 and around line 2000. The code should
probably be moved in to a common function, but attached is a quick
patch to make them match.

At this point the message is completely harmless and only cosmetic.

-Dave
--- src/slonik/slonik.c.orig	2008-03-07 11:01:37.000000000 -0800
+++ src/slonik/slonik.c	2008-05-16 15:15:28.000000000 -0700
@@ -1909,7 +1909,7 @@
 		use_major = 8;
 		use_minor = 1;
 	}
-	else	/* 8.3+ */
+	else	/* 8.4+ */
 	{
 		use_major = 8;
 		use_minor = 1;
@@ -2004,18 +2004,18 @@
                 use_major = 8;
                 use_minor = 0;
         }
-       else if ((adminfo->pg_version >= 80100) && adminfo->pg_version < 80300)	/* 8.1 and 8.2 */
+       else if ((adminfo->pg_version >= 80100) && adminfo->pg_version < 80400)	/* 8.1, 8.2 and 8.3 */
        {
 	       use_major = 8;
 	       use_minor = 1;
        }
-        else    /* 8.3 and above */
+        else    /* 8.4+ */
         {
                 use_major = 8;
                 use_minor = 1;
                 printf("%s:%d: Possible unsupported PostgreSQL "
-                        "version %d.%d, defaulting to 8.1 support\n",
-                        stmt->stmt_filename, stmt->stmt_lno,
+                        "version (%d) %d.%d, defaulting to 8.1 support\n",
+                        stmt->stmt_filename, stmt->stmt_lno, adminfo->pg_version,
                         (adminfo->pg_version/10000), ((adminfo->pg_version%10000)/100));
         }
 
_______________________________________________
Slony1-general mailing list
[email protected]
http://lists.slony.info/mailman/listinfo/slony1-general

Reply via email to