Hello,

I'm creating a new scheduling plugin and so far while browsing through the SLURM source code I found these bugs:

1)
File: job_scheduler.c
Line: 1769 & 1770
Code: "if (part_node_cnt > part_cpu_cnt)"
This should be other way around -> "if (part_cpu_cnt > part_node_cnt)"
Same thing in the line 1770.

2)
File: job_scheduler.c
Line: 1791
Code: "if (job_ptr->time_limit == NO_VAL)"
This is a typo, should be -> "job_q_ptr->time_limit"

3)
File: job_mgr.c
Line: 8216
Code: "if ((job_ptr->priority == 1) &&"
I'm not 100% sure, but shouldn't this be -> "priority == 0" ?
The idea is to recalculate the priority if the job was held?

Best regards,
Filip Skalski

Reply via email to