Quoting Filip Skalski <[email protected]>:
Hello,
I'm creating a new scheduling plugin and so far while browsing
through the SLURM source code I found these bugs:
1)
File: job_scheduler.c
Line: 1769 & 1770
Code: "if (part_node_cnt > part_cpu_cnt)"
This should be other way around -> "if (part_cpu_cnt > part_node_cnt)"
Same thing in the line 1770.
2)
File: job_scheduler.c
Line: 1791
Code: "if (job_ptr->time_limit == NO_VAL)"
This is a typo, should be -> "job_q_ptr->time_limit"
3)
File: job_mgr.c
Line: 8216
Code: "if ((job_ptr->priority == 1) &&"
I'm not 100% sure, but shouldn't this be -> "priority == 0" ?
The idea is to recalculate the priority if the job was held?
The check for priority == 1 should be removed here and in one other place.
Thank you for the patches. I committed these changes as two patches
shown below and the changes will be in version 2.6.4.
https://github.com/SchedMD/slurm/commit/0b68c2edceb54c66f796f9084148e78e052ca5bb
https://github.com/SchedMD/slurm/commit/e1dce4a5a9668ffb0382ddaf1200be80aa118397
Best regards,
Filip Skalski
