Some issues with the cmake buildsystem I've found:
- the dependency on boost date_time seems optional, so it should not be
enforced by cmake (cmake/dependencies/Boost.cmake:3)
- the testcases produce build errors when the backend dependencies are not
met (added patch to tracker)
- postgresql backend does not require postgresql to build. Intentional?
- firebird obdc and oracle cmake builds missing
Also for the SOVERSION ${SOCI_VERSION} target property from my patch should
be adapted to your versioning scheme
If should only be incremented when you change the api, not for every minor
release
not related to build:
- backend/sqlite3/common.h function name style does not match with the rest
(it uses uppercase letters)
On Sun, Sep 5, 2010 at 1:52 AM, Denis Arnaud <[email protected]>wrote:
> 2010/9/5 Mateusz Loskot <[email protected]>
>
> Basically, I'd appreciate if you could try to build SOCI using CMake
>> on your systems and in whatever configuration you can do it
>> and please report any problems, suggestions and fixes here.
>>
>
> On Fedora 13, it works.
>
>
>> I'm interested in any comments, regarding usability, reliability,
>> cosmetics, anything.
>>
>
> 0. First of all, you have done very good work, and the result is pretty
> neat!
> I appreciate that the backend-specific headers are now installed in
> dedicated include directories, and that the sonames are now correctly set.
> 1. A small thing: usually (for other projects using CMake), there is no
> "build" directory, as it is the one we create to build temporary objects
> with CMake and makefiles. So, we could maybe rename that directory?
> 2. Note: the CMAKE_INSTALL_PREFIX must be correctly set, if needed, for
> instance:
> mkdir tmp; cd tmp; cmake
> -DCMAKE_INSTALL_PREFIX:PATH=/home/dan/dev/deliveries/soci-3.1.0 ../src/;
> make install
>
> So, thanks a lot for that nice work :)
>
> Regards
>
> Denis
>
>
>
> ------------------------------------------------------------------------------
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> _______________________________________________
> Soci-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/soci-users
>
>
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Soci-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/soci-users
