Hi Julian,
Thank you for testing.
On 05/09/10 14:58, Julian Taylor wrote:
> Some issues with the cmake buildsystem I've found:
> - the dependency on boost date_time seems optional, so it should not be
> enforced by cmake (cmake/dependencies/Boost.cmake:3)
Fixed in the repo.
> - the testcases produce build errors when the backend dependencies are
> not met (added patch to tracker)
I'll review and submit tomorrow.
> - postgresql backend does not require postgresql to build. Intentional?
How is that? I believe I've set PostgreSQL as requirement for the
PostgreSQL backend, so find_package(PostgreSQL) is issued
and results are tested.
Could you explain what you mean?
> - firebird obdc and oracle cmake builds missing
I have started configuring Oracle. The problem is that I have 64-bit
machine and only 32-bit binaries of Oracle and haven't found time to
play with CMake arch cross-compiling yet.
Regarding the other two, yes, unfortunately, they seem to be orphaned a
bit. I'm hoping to make update to ODBC backend myself sooner than later.
By the way, I build ODBC backend using Visual Studio projects and I
found running tests crash mysteriously. I'd appreciate help in testing this.
> Also for the SOVERSION ${SOCI_VERSION} target property from my patch
> should be adapted to your versioning scheme
> If should only be incremented when you change the api, not for every
> minor release
Good point, I'll take a look at it.
FYI, I have dropped the naming covention used in previous SOCI versions
and based on Boost concept using indicators of debug/release,
single/multi-thread, etc.
CMake config simply generates libsoci_core, libsoci_sqlite2, etc.
> not related to build:
> - backend/sqlite3/common.h function name style does not match with the
> rest (it uses uppercase letters)
Fixed.
Thanks!
Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net
Charter Member of OSGeo, http://osgeo.org
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Soci-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/soci-users
