Marc Kleine-Budde wrote: > Wolfgang Grandegger wrote: >> This patch makes the private functions alloc_can_skb() and >> alloc_can_err_skb() of the at91_can driver public and adapts all >> drivers to use these. While making the patch I realized, that >> the skb's are *not* setup consistently. The skb's are now setup >> as shown: > >> skb->dev = dev; > > nitpick: we use "netdev_alloc_skb()", so "skb->dev = dev" isn't needed > any more. The code is allright, just the commit message is misleading. > >> skb->protocol = __constant_htons(ETH_P_CAN); >> skb->ip_summed = CHECKSUM_UNNECESSARY; > >> Some drivers or library code used: > >> skb->protocol = htons(ETH_P_CAN); or >> skb->pkt_type = PACKET_BROADCAST; > >> or did not set CHECKSUM_UNNECESSARY. > >> Please check and comment. > >> Marc, feel free to add your signed-off-by here. > > nitpick: as you did the patch, I can rather add my Acked-by: under your > S-o-b.
Well, you are involved in the development of the patch and the first signed-off-by could be yours, I think. But an acked-by is fine as well. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
