Oliver Hartkopp wrote: > Wolfgang Grandegger wrote: >> Oliver Hartkopp wrote: >>> Wolfgang Grandegger wrote: >>>> Oliver Hartkopp wrote: >>>>> Wolfgang Grandegger wrote: >>>>>> Oliver Hartkopp wrote: >>>>>>> Hi Wolfgang, >>>> [snip] >>>>>> For this >>>>>> reason I was also happy with the EMS USB CAN driver in the top-level >>>>>> directory. >>>>> Indeed what data is transferred in the urbs is very CAN USB adapter >>>>> specific. >>>>> For that reason we won't have been able to map USB drivers to CAN >>>>> controllers >>>>> anyway. >>>>> >>>>>>> But at least we should move the Kconfigs into the subdirs as suggested >>>>>>> in my >>>>>>> patch. >>>>>> Yes, this is less error prune. Are you going to provide a patch? >>>>> Yes. I can do so. >>>>> >>>>> Does it make sense to you to define a CONFIG_CAN_USB analogue to >>>>> CONFIG_CAN_SJA1000 ?? >>>> No, why? There is no user. >>> It just looked very nice in menuconfig to open a new indented section for >>> CAN >>> USB adaptors. >>> >>> But this can be done later on also ... >> Then use something similar to: >> >> $ cat drivers/net/usb/Kconfig >> ... >> menu "USB Network Adapters" >> depends on USB && NET > > Will do.
Maybe we should do that then for SJA1000 drivers as well. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
