Oliver Hartkopp wrote:
> Oliver Hartkopp wrote:
>> Hi Wolfgang,
>>
>> i created a patch for the Kconfig problem that has come up with the EMS USB
>> config entry in 2.6.32-rcX.
>>
>> Can you check, if it's ok for you?
>>
> 
> Just a small update using 'if' and 'endif' in sja1000/Kconfig to omit the
> permanent "depends on CAN_SJA1000" stuff.

I'm not a friend of using that type if if's in Kconfig. Apart from that
the patch looks good. Just one minor nitpicking. I would write:

+menuconfig CAN_SJA1000
+       depends on CAN_DEV && HAS_IOMEM
+       tristate "NXP/Philips SJA1000 CAN controller drivers"

Thanks for overtaking.

Wolfgang.
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to