Oliver Hartkopp wrote: > Wolfgang Grandegger wrote: >> Oliver Hartkopp wrote: >>> Oliver Hartkopp wrote: >>>> Hi Wolfgang, >>>> >>>> i created a patch for the Kconfig problem that has come up with the EMS USB >>>> config entry in 2.6.32-rcX. >>>> >>>> Can you check, if it's ok for you? >>>> >>> Just a small update using 'if' and 'endif' in sja1000/Kconfig to omit the >>> permanent "depends on CAN_SJA1000" stuff. >> I'm not a friend of using that type if if's in Kconfig. > > But it's the usual way - i doublechecked that right now.
OK, let's try that and see if we get an NACK. >> Apart from that >> the patch looks good. Just one minor nitpicking. I would write: >> >> +menuconfig CAN_SJA1000 >> + depends on CAN_DEV && HAS_IOMEM >> + tristate "NXP/Philips SJA1000 CAN controller drivers" > > Which is misleading. > > We provide just *one* SJA1000 driver but several SJA1000 based devices. > > I tend to change > > "Philips/NXP SJA1000 CAN controller based devices" > to > "Philips/NXP SJA1000 based devices" We provide drivers and not device. That's my concern. But it's a minor issue anyhow, just go ahead. Wolfgang. > to reduce the bla bla :-) > > >> Thanks for overtaking. > > I think fixing this up is important for 2.6.32 where the problem came in with > the USB driver. The later we fix this the bigger the mess ... > > And AFAIK you need to cook a patch for the xstats for 2.6.32 anyway - and > you're already on heavy load. Will do soon, but so far that was not a real problem. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
