Wolfgang Grandegger wrote:
>>> Please also check for useless "dlc > 8" checks in the
>>> start_xmit function.
>> I thought about that and i'm not really sure about it:
>> What if anyone uses PF_PACKET with CAN netdevices, which is a possible
>> use-case?
>
> OK.
Any ideas how to proceed in the start_xmit functions?
We could add something like this consistently to *all* start_xmit functions:
Index: drivers/net/can/sja1000/sja1000.c
===================================================================
--- drivers/net/can/sja1000/sja1000.c (Revision 1095)
+++ drivers/net/can/sja1000/sja1000.c (Arbeitskopie)
@@ -257,6 +257,13 @@
uint8_t dreg;
int i;
+ if (WARN_ONCE(skb->len != sizeof(*cf) || cf->can_dlc > 8,
+ "Dropped non conform skbuf: len %d, can_dlc %d\n",
+ skb->len, cf->can_dlc)) {
+ kfree_skb(skb);
+ return 0;
+ }
+
netif_stop_queue(dev);
fi = dlc = cf->can_dlc;
Regards,
Oliver
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
