Wolfgang Grandegger wrote: > Hi Oliver, > > Oliver Hartkopp wrote: >> Wolfgang Grandegger wrote: >>> Oliver Hartkopp wrote: >>>>>> i updated the SVN and introduced a new GET_CAN_DLC() macro, that casts >>>>>> the >>>>>> data length code information to __u8 and ensures the dlc not to be > 8 . >>>>> I like your approach. I'm just not happy with the name. We should use >>>>> the prefix "can_" for public functions and lower-case seems also more >>>>> appropriate. A "static inline" is less handy, I agree. Therefore I vote >>>>> for "can_get_dlc()". Also some description for that macro would be nice. >>>> No problem. >>>> >>>> So you would suggest to s/GET_CAN_DLC/can_get_dlc/g to rename the macro, >>>> right? >>> Well, yes, also "get_can_dlc" would be fine as we already have >>> alloc_candev, etc. >> Done. >> >> Indeed the documentation was missing ;-) > > Are you going to prepare a patch for mainline as well?
Yep. Will do. As there was no negative feedback, i'll prepare a patch the next days. Regards, Oliver _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
