On 10/21/2010 08:34 PM, Ira W. Snyder wrote: > On Thu, Oct 21, 2010 at 07:53:31PM +0200, Marc Kleine-Budde wrote: >> This patch cleans up the ICAN3 to Linux CAN Frame Conversion function: >> >> - Use get_can_dlc() to limit the dlc value. >> - Don't copy the whole frame, only copy the amount of bytes specified >> in cf->can_dlc. >> >> Signed-off-by: Marc Kleine-Budde <[email protected]> >> Cc: Ira W. Snyder <[email protected]> > > Looks fine. If you're up for it, roll the following into the same patch. > It forces the TX path to respect the cf->can_dlc length when memcpy()ing > data into the transmit frame. > > For the patch as-is, please add my Acked-by.
Thanks, I squashed you patch added you Ack. I was free to add your S-o-b, too, okay? cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
