Marc,

> This series of patches changes the can drivers RX path. If a RTR frame is
> received no data is copied.

1 remark to all patches:
instead of copying 8 databytes, you now copy "can_dlc" bytes.

can_dlc is minimum 4bits, but the struct can_frame is only 8 bytes.
Is this safe?
Would memcpy(msg->data, REGS, MINIMUM(8, msg->can_dlc)) be better/safe?

The rest of the patches look great.
Kurt
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to