On Mon, Mar 14, 2011 at 03:09:15PM +0100, Eric Dumazet wrote:
> Le lundi 14 mars 2011 à 14:47 +0100, Kurt Van Dijck a écrit :
> > can_ioctl is the only reason for struct proto to be non-const.
> > script/check-patch.pl suggests struct proto be const.
> > This patch performs the necessary change.
> >
> > static void can_sock_destruct(struct sock *sk)
> > {
> > @@ -720,10 +721,6 @@ int can_proto_register(const struct can_proto *cp)
> > err = -EBUSY;
> > } else {
> > proto_tab[proto] = cp;
> > -
> > - /* use generic ioctl function if not defined by module */
> > - if (!cp->ops->ioctl)
> > - cp->ops->ioctl = can_ioctl;
>
> Hmm, you actually fixed a race / bug, since we installed in proto_tab[]
> a pointer to a not yet initted ops structure.
I see your point.
The reason I modified this was, as described, checkpatch.pl was complaining.
Anyway, this sequence was protected by a spinlock 'proto_tab_lock'.
I don't think it was a race.
Did I miss something?
Kurt
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
