Hi, On Thu, Nov 26, 2009 at 01:09:55PM +0100, Wolfgang Grandegger wrote: > Wolfgang Grandegger wrote: > > Hi Fu, > > > > Luotao Fu wrote: <snip> > > Just looked to the code. scan_do_restart() just does the bus-off > recovery if appropriate. But I realized that the scan_set_* functions do > stop the device before setting the property. That's dangerous and error > prune and therefore we did not allow it in the kernel. It's up to the > user/application to handle up/down properly. Furthermore, these > functions seem to start the device even if it was not up before. >
I updated the GIT tree. Now we have scan_do_start/stop/restart callbacks to start/stop/restart the device. Also elimanated duplicated code and remove the internal starting/stoping the device in _set calls. canconfig is updated too. I will rename the library to simply libsocketcan and the API prefix to can_. All good with these names? cheers Fu -- Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: Digital signature
_______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
