On 07/20/2011 04:52 PM, Oliver Hartkopp wrote: > On 20.07.2011 16:32, Marc Kleine-Budde wrote: ... > Thanks for testing, Mike. > > So you have the echo of sent CAN frames on driver level again. > Which is much better than the workaround in the af_can.c without IFF_ECHO. > > Marc, would you like to give these guys some feedback about the regression due > to their modification? > >> Signed-off-by: Bhaskar Upadhaya <bhaskar.upadhaya at freescale.com> >> Acked-By: Scott Wood <scottwood at freescale.com> > > Probably they did not understand, why the 'echo' functionality has been > introduced. Making modifications for a new device binding is fine - but > changing the mainline code, so that people get unusual behaviour is bad.
Also, with the new device-tree bindings they broke the platform code necessary for ARM. Therefore the code is not mainline'able, anyway. Well, it would be nice if the Freescale developers would work closer together with the community but the focus is obviously on providing quick support for their new eval-boards for exactly one kernel version. Wolfgang. _______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
