On 07/20/2011 04:52 PM, Oliver Hartkopp wrote: > So you have the echo of sent CAN frames on driver level again. > Which is much better than the workaround in the af_can.c without IFF_ECHO. > > Marc, would you like to give these guys some feedback about the regression due > to their modification?
Good idea - now that we have the driver.... done >> Signed-off-by: Bhaskar Upadhaya <bhaskar.upadhaya at freescale.com> >> Acked-By: Scott Wood <scottwood at freescale.com> > > Probably they did not understand, why the 'echo' functionality has been > introduced. Making modifications for a new device binding is fine - but > changing the mainline code, so that people get unusual behaviour is bad. cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
