On 08/01/2011 03:32 PM, Wolfgang Grandegger wrote: > Hi Marc, > > On 08/01/2011 02:55 PM, Marc Kleine-Budde wrote: >> On 08/01/2011 02:17 PM, Thomas Wiedemann wrote: >>> Hi, >>> >>> i've attached a patch for the Peak CAN PCI driver, which enables support >>> for the 3rd and 4th channel available on some cards. It works* for me. >> >> Thanks for the patch. Please don't attach patches, rather post them >> inline. Please follow the cannonical patch format as documented here: >> http://lxr.linux.no/linux+v3.0/Documentation/SubmittingPatches >> >> See further remarks inline. >> >> I just noticed that this patch is against the berlios tree. I don't know >> if there is a mainline driver that supports the peak pci cards. > > No, there is't. But maybe Thomas is interested to push it mainline, > after some more fixes. It should be implemented like the other PCI > drivers, e.g. ems_pci or even the plx_pci driver might be OK. I need to > check. I could then provide a patch which Thomas may test on his > hardware. I have a two-channel PCAN-PCI card available.
Adding peak support to one of the existing drivers is a good idea. What's the general plan for the ems and plx drivers. Can they be merged? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
