Hi Thomas, On 08/01/2011 04:08 PM, Thomas Wiedemann wrote: > Wolfgang Grandegger <[email protected]> schrieb am 01.08.2011 15:58:54: >> On 08/01/2011 03:54 PM, Thomas Wiedemann wrote: >>> Wolfgang Grandegger <[email protected]> schrieb am 01.08.2011 > 15:32:14: >>>> Hi Marc, >>>> >>>> On 08/01/2011 02:55 PM, Marc Kleine-Budde wrote: >>>>> On 08/01/2011 02:17 PM, Thomas Wiedemann wrote: >>>>>> Hi, >>>>>> >>>>>> i've attached a patch for the Peak CAN PCI driver, which enables >>> support >>>>>> for the 3rd and 4th channel available on some cards. It works* for >>> me. >>>>> >>>>> Thanks for the patch. Please don't attach patches, rather post them >>>>> inline. Please follow the cannonical patch format as documented > here: >>>>> http://lxr.linux.no/linux+v3.0/Documentation/SubmittingPatches >>>>> >>>>> See further remarks inline. >>>>> >>>>> I just noticed that this patch is against the berlios tree. I don't >>> know >>>>> if there is a mainline driver that supports the peak pci cards. >>>> >>>> No, there is't. But maybe Thomas is interested to push it mainline, >>>> after some more fixes. It should be implemented like the other PCI >>>> drivers, e.g. ems_pci or even the plx_pci driver might be OK. I need > to >>>> check. I could then provide a patch which Thomas may test on his >>>> hardware. I have a two-channel PCAN-PCI card available. >>> >>> It makes no big difference for me whether it is in mainline or not, > the >>> socket-can tree from berlios is fine. I would rather not have to > bother >>> with your coding style ;) >> >> Well, it's also not *my* coding style ;-). >> >>> But if you'd provide a patch, i would surely test it. >> >> That would be great. I will have time middle of August to work on this >> driver. > > Fine. > When you rewrite the whole driver, I guess it does not make sense for me > to rewrite the patch with Marc's hints then, right? (beside of getting > some practice on kernel coding style for the next patch ;)
Unfortunately, the Socket-CAN-Repository at BerliOS is not really in good shape, e.g. up-to-date and I'm not sure, if I will finally backport it. Therefore, please fix the remaining issues and we will apply it without further nitpicking... for the time being. What kernel version are you using? Any chance to switch to 3.x? Thanks, Wolfgang. _______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
