Hi All,
Regarding my patch on using upstream pygerrit. I made some changes in
pysflib. But the install_pygerrit function in softwarefactory.install
(https://github.com/redhat-cip/software-factory/blob/17b1c5c2d62cfd5b8475815f86dc0426ee55a187/image/softwarefactory.install#L240)
uses the forked version. I am not sure how it falls into the picture.
This has to be also changed right (in another patch) ?
Also I thought I would need to change the tests code here :
https://github.com/redhat-cip/pysflib/blob/028f7121feadd72d761d11f372caf19cfc324925/pysflib/tests/test_sfgerrit.py#L43.
However I didn't change anything. (I am not familiar with Mock testing,
learning on the way)
But the functional tests passed locally. Any comments on the 2nd?
Regards,
Aslam
_______________________________________________
Softwarefactory-dev mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/softwarefactory-dev
