On 01/29/2016 01:34 PM, aslam wrote: > > > Hi All, > > Regarding my patch on using upstream pygerrit. I made some changes in > pysflib. But the install_pygerrit function in softwarefactory.install > (https://github.com/redhat-cip/software-factory/blob/17b1c5c2d62cfd5b8475815f86dc0426ee55a187/image/softwarefactory.install#L240) > > uses the forked version. I am not sure how it falls into the picture. > This has to be also changed right (in another patch) ?
Hello Aslam, a few note about sf image build process... So sub-project requirements.txt are *not* installed in the images, this caused too much trouble to rely on dynamics pip installation. Instead, all requirements (of managesf, pysflib, cauth and python-sfmanager) are installed in the cache (step1). Sub projects are installed using python setup.py install in the image (step2). So you're correct, once pysflib is working fine with upstream pygerrit, then you need to replace the install_pygerrit from softwarefactory.install by the upstream packages. Maybe just removed the function and add pygerrit to image/packages/pip_pkgs.txt Hope that makes sense, - Tristan
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Softwarefactory-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/softwarefactory-dev
