On 1/20/07, Chris Hostetter <[EMAIL PROTECTED]> wrote:
Ryan: this patch truely does kick ass ... we can probably simplify a lot of the Legacy stuff by leveraging your new StandardRequestBuilder -- but that can be done later.
Much is already done by the looks of it.
i'm stil really not liking the way there is a single SolrRequestBuilder with a big complicated build method that "guesses" what streams the user wants.
But I don't need a separate URL to do GET vs POST in HTTP. It seems like having a different URL for where you put the args would be hard to explain to people.
i really feel strongly that even if all the parsing logic is in the core, even if it's all in one class: a piece of the path should be used to determine where the streams come from.
If there's a ? in the URL, then it's args, so that could always safetly be parsed. Perhaps a special arg, if present, could override the default method of getting input streams?
consider the example you've got on your test.html page: "POST - with query string" ... that doesn't obey the typical semantics of a POST with a query string ... if you used the methods on HttpServletRequest to get the params it would give you all the params it found both in the query strings *and* in the post body.
Blech. I was wondering about that. Sounds like bad form, but perhaps could be supported via something like /solr/foo?postbody=args -Yonik
