: Great! I just posted an update to SOLR-104 that I hope will make you happy.
Dude ... i can *not* keep up with you. : If i'm following our discussion correctly, I *think* this takes care : of all the major issues we have. I don't think i'll have time to look at your new patch today, design wise i think you are right, but there was still stuff that needed to be refactored out of core.update and into the UpdateHandler wasn't there? a couple of minor comments i had when i read the last patch (but didn't mention since i was focusing on design issues) ... 1) why rename the servlets "Legacy*" instead of just marking them deprecated? 2) getSourceId and getSoure need to be left in the concrete Handlers so they get illed in with the correct file version info on checkout. 3) there's a comment in RequestHandlerBase.init about "indexOf" that comes form the existing impl in DismaxRequestHandler -- but doesn't match the new code ... i also wasn't certain that the change you made matches the old semantics for dismax (i don't think we have a unit test for that case) 4) ContentStream.getFieldName() would proabably be more general as ContentStream.getSourceInfo() ... it could stay as it is for files/urls, but raw posts and multipart posts could have a usefull debuging description as well. -Hoss
