: > > 3) there's a comment in RequestHandlerBase.init about "indexOf" that : > > comes form the existing impl in DismaxRequestHandler -- but doesn't match : > > the new code ... i also wasn't certain that the change you made matches
: > I just copied the code from DismaxRequestHandler and made sure it : > passes the tests. I don't totally understand what that case is doing. : : The first iteration of dismax (before we did generic defaults, : invariants, etc for request handlers) took defaults directly from the : init params, and that is what that case is checking for and bingo .. the reason it jumped out at me in your patch, is that the comment still refered to indexOf, but the code didn't ... it might be functionally equivilent, i just wasn't sure when i did my quick read. there's mention in the comment that indexOf is used so that <null name="defaults" /> can indicate that you don't want all the init params as defaults, but you don't acctually want defaults either -- but there doesn't seem to be a test for that case. you can see support for the legacy defaults syntax in src/test/test-files/solr/conf/solrconfig.xml if you grep for dismaxOldStyleDefaults -Hoss
