[ 
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466912
 ] 

Yonik Seeley commented on SOLR-104:
-----------------------------------

Finally got a chance to review this... it's really great stuff Ryan!

Random questions:
- What's the funny chars at the start of web.xml?
- Why is there a 2MB upload limit, and why does it only apply to multi-part 
uploads?  I think I'm missing some background in this area...

I'm not going to try and pick out little bugs or suggest little changes to a 
patch of this scope and size...
I think we should have more frequent Solr releases, and that the Solr trunk  
can have APIs change from one day to the next w/o having to maintaining 
back-compatibility.

So since we agree on the direction, I think this patch should be committed and 
we should work from there.
I'd like to hear from hoss though, since he was following along more than I 
was, esp at the start of that marathon thread.

> Update Plugins
> --------------
>
>                 Key: SOLR-104
>                 URL: https://issues.apache.org/jira/browse/SOLR-104
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 1.2
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: commons-fileupload-20070107.jar, commons-io-1.2.jar, 
> DispatchFilter.patch, DispatchFilter.patch, DispatchFilter.patch, 
> DispatchFilter.patch, DispatchFilter.patch, HandlerRefactoring-DRAFT-SRC.zip, 
> HandlerRefactoring-DRAFT-SRC.zip, HandlerRefactoring.DRAFT.patch, 
> HandlerRefactoring.DRAFT.patch, HandlerRefactoring.DRAFT.zip
>
>
> The plugin framework should work for 'update' actions in addition to 'search' 
> actions.
> For more discussion on this, see:
> http://www.nabble.com/Re%3A-Handling-disparate-data-sources-in-Solr-tf2918621.html#a8305828

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to