Bertrand: Just some comments from the sideline..
Here's my understanding of our current (but largely unwritten IIUC) way of working.
The word here is "unwritten". This is where is the problem with loads of apache project. Its the few privileged who decides what is a "rule" or "coding conduct". So unwritten rule is a great way of working so long you are singing the same song.
1. Solr usually works in RTC mode: patches are first posted to Jira, then committed once we agree on a particular patch. This does not apply to obvious fixes, typos, etc., of course.
So "usually" works? So how do you agree? are there any rules there or is it also unwritten? Sorry I have a hard time understanding how things gets to trunk. Cos when you look at Solr Jira seems like 90% of the issues are unassigned where 50% being major and 50% being minor. Obviously there are some community needs for those patches, some are bad some are good nevertheless those who are submitting patch should get a honest reply in a decent time frame.
2.. Non-trivial patches require a [VOTE] on the dev list before being committed. What's "non-trivial"? I'd suggest using our common sense and trusting each other to judge this, for a start. 3. Patches, and especially those adding new functionality, must be accompanied by automated tests and some documentation (usually in the Solr wiki). 4. If needed, we could create svn branches for wild experimental stuff, but we prefer to work with small incremental patches if possible.
Your comments here are very general, vague, wide open shots. I think if there are any commits that Ryan made is not to your liking or patch doesn't have test/docs what not then it can be reverted after all its a subversion and its not a part of a release. I been following the list and Ryan made great patches and he has the drive/time and blessings from the PMC so why stop the good thing and his enthusiasm. Just some comments from the sideline Rajesh.
