[ https://issues.apache.org/jira/browse/SOLR-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499294 ]
John Wang commented on SOLR-243: -------------------------------- 1) Sorry about this, my eclipse IDE showed 2 spaces. I will remember in the future. 2) Sorry about this one as well, I changed them from public to private to do some testing and forgot to change them back. I have no problem with them being public. 3) That sounds good. I just picked a spot in solrConfig.xml 4) Sure. 5) I think that is a coding style, but I am not religious about it. 6) That is a great idea! I wanted to add this but wasn't sure how to do it. 7) Ok. Thanks for the code review! -John > Create a hook to allow custome code to create custome index readers > ------------------------------------------------------------------- > > Key: SOLR-243 > URL: https://issues.apache.org/jira/browse/SOLR-243 > Project: Solr > Issue Type: Improvement > Components: search > Affects Versions: 1.3 > Environment: Solr core > Reporter: John Wang > Fix For: 1.3 > > Attachments: indexReaderFactory.patch > > > I have a customized IndexReader and I want to write a Solr plugin to use my > derived IndexReader implementation. Currently IndexReader instantiation is > hard coded to be: > IndexReader.open(path) > It would be really useful if this is done thru a plugable factory that can be > configured, e.g. IndexReaderFactory > interface IndexReaderFactory{ > IndexReader newReader(String name,String path); > } > the default implementation would just return: IndexReader.open(path) > And in the newSearcher and getSearcher methods in SolrCore class can call the > current factory implementation to get the IndexReader instance and then build > the SolrIndexSearcher by passing in the reader. > It would be really nice to add this improvement soon (This seems to be a > trivial addition) as our project really depends on this. > Thanks > -John -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.