[ 
https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508007
 ] 

Yonik Seeley commented on SOLR-267:
-----------------------------------

> I'm really not a fan of this approach to logging the number of hits via 
> SolrCore.execute ... this is request handler specific information, it should 
> be logged by the request handler.

There is something to be said for automatically logging certain things for all 
request handlers in a certain category (those that produce a "base" DocList or 
DocSet) rather than requiring each handler to worry about logging code also.

The implementation is slightly hackish at this point, but not too bad.  If/when 
we go to a QueryComponent chain, it would be cleaner to get "hits".

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, 
> LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to