[ 
https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514588
 ] 

Sharad Agarwal commented on SOLR-256:
-------------------------------------

I earlier tried with findMBeanServer(null) with tomcat; and it always return me 
non-empty list of mbeanservers irrespective of JMX enabled or not. In tomcat it 
gets enabled via system properties.
So to me it seems that having mbean server instance may not really confirm that 
JMX is enabled or not. 

Saying that, i think it may be OK to have the MonitoredMap even when JMX is not 
enabled. (dont think any overhead in using MonitoredMap); whenever JMX is 
enabled by either of the ways (standard system properties or via jetty config), 
both would work fine.



> Stats via JMX
> -------------
>
>                 Key: SOLR-256
>                 URL: https://issues.apache.org/jira/browse/SOLR-256
>             Project: Solr
>          Issue Type: New Feature
>          Components: search, update
>            Reporter: Sharad Agarwal
>            Priority: Minor
>         Attachments: jmx.patch, jmx.patch, jmx.patch, jmx.patch, jmx.patch
>
>
> This patch adds JMX capability to get statistics from all the SolrInfoMBean.
> The implementation is done such a way to minimize code changes. 
> In SolrInfoRegistry, I have overloaded Map's  put and remove methods to 
> register and unregister SolrInfoMBean in MBeanServer. 
> Later on, I am planning to use register and unregister methods in 
> SolrInfoRegistry and removing getRegistry() method (Hiding the map instance 
> to other classes)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to